Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce "codegenConfig.isLibrary" property #41655

Closed
wants to merge 1 commit into from

Conversation

dmytrorykun
Copy link
Contributor

Summary:
This diff adds support for checked-in codegen artifacts for libraries.
It introduces a new property to coegenConfig, called isLibrary. If codegen sees isLibrary: true in a project's dependency, it assumes that the library has codegen artifacts in it, and will not generate any code.

Changelog: [General][Added] - Introduce "codegenConfig.isLibrary" property.

Differential Revision: D51207265

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Nov 27, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51207265

@analysis-bot
Copy link

analysis-bot commented Nov 27, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 16,524,957 -11
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 19,899,769 +5
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: d45a01d
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51207265

dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request Nov 27, 2023
Summary:
Pull Request resolved: facebook#41655

This diff adds support for checked-in codegen artifacts for libraries.
It introduces a new property to `coegenConfig`, called `isLibrary`. If codegen sees `isLibrary: true` in a project's dependency, it assumes that the library has codegen artifacts in it, and will not generate any code.

Changelog: [General][Added] - Introduce "codegenConfig.isLibrary" property.

Differential Revision: D51207265

fbshipit-source-id: 938cf998331a7841731dfcf24e2a3e6ed8bcf8dc
dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request Dec 11, 2023
Summary:

This diff adds support for checked-in codegen artifacts for libraries.
It introduces a new property to `coegenConfig`, called `isLibrary`. If codegen sees `isLibrary: true` in a project's dependency, it assumes that the library has codegen artifacts in it, and will not generate any code.

Changelog: [General][Added] - Introduce "codegenConfig.isLibrary" property.

Reviewed By: cipolleschi

Differential Revision: D51207265
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51207265

dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request Dec 12, 2023
Summary:

This diff adds support for checked-in codegen artifacts for libraries.
It introduces a new property to `coegenConfig`, called `isLibrary`. If codegen sees `isLibrary: true` in a project's dependency, it assumes that the library has codegen artifacts in it, and will not generate any code.

Changelog: [General][Added] - Introduce "codegenConfig.isLibrary" property.

Reviewed By: cipolleschi

Differential Revision: D51207265
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51207265

dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request Dec 13, 2023
Summary:

This diff adds support for checked-in codegen artifacts for libraries.
It introduces a new property to `coegenConfig`, called `isLibrary`. If codegen sees `isLibrary: true` in a project's dependency, it assumes that the library has codegen artifacts in it, and will not generate any code.

Changelog: [General][Added] - Introduce "codegenConfig.isLibrary" property.

Reviewed By: cipolleschi

Differential Revision: D51207265
dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request Dec 14, 2023
Summary:

This diff adds support for checked-in codegen artifacts for libraries.
It introduces a new property to `coegenConfig`, called `isLibrary`. If codegen sees `isLibrary: true` in a project's dependency, it assumes that the library has codegen artifacts in it, and will not generate any code.

Changelog: [General][Added] - Introduce "codegenConfig.isLibrary" property.

Reviewed By: cipolleschi

Differential Revision: D51207265
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51207265

dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request Dec 14, 2023
Summary:

This diff adds support for checked-in codegen artifacts for libraries.
It introduces a new property to `coegenConfig`, called `isLibrary`. If codegen sees `isLibrary: true` in a project's dependency, it assumes that the library has codegen artifacts in it, and will not generate any code.

Changelog: [General][Added] - Introduce "codegenConfig.isLibrary" property.

Reviewed By: cipolleschi

Differential Revision: D51207265
dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request Dec 14, 2023
Summary:

This diff adds support for checked-in codegen artifacts for libraries.
It introduces a new property to `coegenConfig`, called `isLibrary`. If codegen sees `isLibrary: true` in a project's dependency, it assumes that the library has codegen artifacts in it, and will not generate any code.

Changelog: [General][Added] - Introduce "codegenConfig.isLibrary" property.

Reviewed By: cipolleschi

Differential Revision: D51207265
dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request Dec 15, 2023
Summary:

This diff adds support for checked-in codegen artifacts for libraries.
It introduces a new property to `coegenConfig`, called `isLibrary`. If codegen sees `isLibrary: true` in a project's dependency, it assumes that the library has codegen artifacts in it, and will not generate any code.

Changelog: [General][Added] - Introduce "codegenConfig.isLibrary" property.

Reviewed By: cipolleschi

Differential Revision: D51207265
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51207265

dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request Dec 15, 2023
Summary:

This diff adds support for checked-in codegen artifacts for libraries.
It introduces a new property to `coegenConfig`, called `isLibrary`. If codegen sees `isLibrary: true` in a project's dependency, it assumes that the library has codegen artifacts in it, and will not generate any code.

Changelog: [General][Added] - Introduce "codegenConfig.isLibrary" property.

Reviewed By: cipolleschi

Differential Revision: D51207265
Summary:

This diff adds support for checked-in codegen artifacts for libraries.
It introduces a new property to `coegenConfig`, called `isLibrary`. If codegen sees `isLibrary: true` in a project's dependency, it assumes that the library has codegen artifacts in it, and will not generate any code.

Changelog: [General][Added] - Introduce "codegenConfig.isLibrary" property.

Reviewed By: cipolleschi

Differential Revision: D51207265
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51207265

dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request Dec 15, 2023
Summary:

This diff adds support for checked-in codegen artifacts for libraries.
It introduces a new property to `coegenConfig`, called `isLibrary`. If codegen sees `isLibrary: true` in a project's dependency, it assumes that the library has codegen artifacts in it, and will not generate any code.

Changelog: [General][Added] - Introduce "codegenConfig.isLibrary" property.

Reviewed By: cipolleschi

Differential Revision: D51207265
dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request Dec 15, 2023
Summary:

This diff adds support for checked-in codegen artifacts for libraries.
It introduces a new property to `coegenConfig`, called `isLibrary`. If codegen sees `isLibrary: true` in a project's dependency, it assumes that the library has codegen artifacts in it, and will not generate any code.

Changelog: [General][Added] - Introduce "codegenConfig.isLibrary" property.

Reviewed By: cipolleschi

Differential Revision: D51207265
dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request Dec 15, 2023
Summary:

This diff adds support for checked-in codegen artifacts for libraries.
It introduces a new property to `coegenConfig`, called `isLibrary`. If codegen sees `isLibrary: true` in a project's dependency, it assumes that the library has codegen artifacts in it, and will not generate any code.

Changelog: [General][Added] - Introduce "codegenConfig.isLibrary" property.

Reviewed By: cipolleschi

Differential Revision: D51207265
dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request Dec 15, 2023
Summary:
Pull Request resolved: facebook#41655

This diff adds support for checked-in codegen artifacts for libraries.
It introduces a new property to `coegenConfig`, called `isLibrary`. If codegen sees `isLibrary: true` in a project's dependency, it assumes that the library has codegen artifacts in it, and will not generate any code.

Changelog: [General][Added] - Introduce "codegenConfig.isLibrary" property.

Differential Revision: https://internalfb.com/D51207265

fbshipit-source-id: 74f8b3651de3f4d921a5be5aa7a905c964b43680
dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request Dec 18, 2023
)

Summary:

This diff adds support for checked-in codegen artifacts for libraries.
It introduces a new property to `codegenConfig`, called `includesGeneratedCode`. If codegen sees `includesGeneratedCode: true` in a project's dependency, it assumes that the library has codegen artifacts in it, and will not generate any code.

Changelog: [General][Added] - Introduce "codegenConfig.includesGeneratedCode" property.

Reviewed By: cipolleschi

Differential Revision: D51207265
dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request Dec 18, 2023
)

Summary:
Pull Request resolved: facebook#41655

This diff adds support for checked-in codegen artifacts for libraries.
It introduces a new property to `codegenConfig`, called `includesGeneratedCode`. If codegen sees `includesGeneratedCode: true` in a project's dependency, it assumes that the library has codegen artifacts in it, and will not generate any code.

Changelog: [General][Added] - Introduce "codegenConfig.includesGeneratedCode" property.

Differential Revision: D51207265

Reviewed By: cipolleschi

fbshipit-source-id: a9d4a8a0cf46f9b194dced74fe1de1210685ee2b
dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request Dec 18, 2023
)

Summary:

This diff adds support for checked-in codegen artifacts for libraries.
It introduces a new property to `codegenConfig`, called `includesGeneratedCode`. If codegen sees `includesGeneratedCode: true` in a project's dependency, it assumes that the library has codegen artifacts in it, and will not generate any code.

Changelog: [General][Added] - Introduce "codegenConfig.includesGeneratedCode" property.

Reviewed By: cipolleschi

Differential Revision: D51207265
dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request Dec 18, 2023
)

Summary:
Pull Request resolved: facebook#41655

This diff adds support for checked-in codegen artifacts for libraries.
It introduces a new property to `codegenConfig`, called `includesGeneratedCode`. If codegen sees `includesGeneratedCode: true` in a project's dependency, it assumes that the library has codegen artifacts in it, and will not generate any code.

Changelog: [General][Added] - Introduce "codegenConfig.includesGeneratedCode" property.

Differential Revision: D51207265

Reviewed By: cipolleschi

fbshipit-source-id: 5f6822714005c7eb5ee8019f3691d8d79f9d2b66
dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request Dec 19, 2023
)

Summary:

This diff adds support for checked-in codegen artifacts for libraries.
It introduces a new property to `codegenConfig`, called `includesGeneratedCode`. If codegen sees `includesGeneratedCode: true` in a project's dependency, it assumes that the library has codegen artifacts in it, and will not generate any code.

Changelog: [General][Added] - Introduce "codegenConfig.includesGeneratedCode" property.

Reviewed By: cipolleschi

Differential Revision: D51207265
dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request Dec 19, 2023
)

Summary:
Pull Request resolved: facebook#41655

This diff adds support for checked-in codegen artifacts for libraries.
It introduces a new property to `codegenConfig`, called `includesGeneratedCode`. If codegen sees `includesGeneratedCode: true` in a project's dependency, it assumes that the library has codegen artifacts in it, and will not generate any code.

Changelog: [General][Added] - Introduce "codegenConfig.includesGeneratedCode" property.

Differential Revision: D51207265

Reviewed By: cipolleschi

fbshipit-source-id: 6a604355d57c98f84a22559241c51cc43bbb98c9
dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request Dec 19, 2023
)

Summary:
Pull Request resolved: facebook#41655

This diff adds support for checked-in codegen artifacts for libraries.
It introduces a new property to `codegenConfig`, called `includesGeneratedCode`. If codegen sees `includesGeneratedCode: true` in a project's dependency, it assumes that the library has codegen artifacts in it, and will not generate any code.

Changelog: [General][Added] - Introduce "codegenConfig.includesGeneratedCode" property.

Differential Revision: D51207265

Reviewed By: cipolleschi

fbshipit-source-id: 3ba0f778da6b624c0a9e1ca8d9cb02d3857e4aab
Copy link

This pull request was successfully merged by @dmytrorykun in 21784e2.

When will my fix make it into a release? | Upcoming Releases

@github-actions github-actions bot added the Merged This PR has been merged. label Dec 19, 2023
Othinn pushed a commit to Othinn/react-native that referenced this pull request Jan 9, 2024
)

Summary:
Pull Request resolved: facebook#41655

This diff adds support for checked-in codegen artifacts for libraries.
It introduces a new property to `codegenConfig`, called `includesGeneratedCode`. If codegen sees `includesGeneratedCode: true` in a project's dependency, it assumes that the library has codegen artifacts in it, and will not generate any code.

Changelog: [General][Added] - Introduce "codegenConfig.includesGeneratedCode" property.

Reviewed By: cipolleschi

Differential Revision: D51207265

fbshipit-source-id: 65855fd846e24a53cb18008839121e99eeb59309
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants